Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Improved rule ID:TOMAR_ASSUMIR #9514

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

marcoagpinto
Copy link
Member

Heya, Susana and Pedro,

I have improved the rule to deal with more situations.

Thanks!

@marcoagpinto
Copy link
Member Author

Portuguese (Portugal): 14 total matches
Portuguese (Portugal): 811110 total sentences considered
Portuguese (Portugal): ø0.00 rule matches per sentence

0000_1.txt

It accepts “SPS00”: “de” now.

Copy link
Collaborator

@p-goulart p-goulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I see the point of 'tomar de', so maybe add an example to illustrate that. Otherwise, lgtm.

@marcoagpinto
Copy link
Member Author

Sure, I will add it soon.

I am working on the rule (fixing FPs): INIMIGO_ADVERSÁRIO_ALIADO_OPONENTE

Until I have it finished, I can't make other changes.

@marcoagpinto marcoagpinto merged commit d4c79fe into master Oct 23, 2023
2 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20231023_0535 branch October 23, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants