[nl] improve CompoundAcceptor #9549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnaber
reviewed
Oct 27, 2023
| @@ -96,7 +95,7 @@ private boolean abbrevOk(String nonCompound) { | |||
|
|
|||
| private boolean spellingOk(String nonCompound) throws IOException { | |||
| AnalyzedSentence as = new AnalyzedSentence(new AnalyzedTokenReadings[] { | |||
| new AnalyzedTokenReadings(new AnalyzedToken(nonCompound, "FAKE_POS", "fakeLemma")) | |||
| new AnalyzedTokenReadings(new AnalyzedToken(nonCompound.toLowerCase(), "FAKE_POS", "fakeLemma")) | |||
There was a problem hiding this comment.
After having merged the PR, I wonder whether this change is ok: aren't there words like country names or names in general that are always uppercase and that won't be accepted when lowercased? These are probably less likely to appear as part of a compound, but maybe you can add a test case for them anyway?
There was a problem hiding this comment.
Yes, there are some exceptions that will still have uppercases. Like you said, less likely, but I'll think of a better solution for them as I add more words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.