Add charliecloud module load to Beeflow #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtronge
reviewed
Aug 25, 2023
beeflow/cli.py
Outdated
| @@ -218,14 +218,21 @@ def version_str(version): | |||
| """Convert a version tuple to a string.""" | |||
| return '.'.join([str(part) for part in version]) | |||
|
|
|||
| def load_charliecloud(): | |||
| """Load the charliecloud module if it exists.""" | |||
| subprocess.run('module load charliecloud', shell=True, check=True) | |||
There was a problem hiding this comment.
Will this affect the environment of the current process?
There was a problem hiding this comment.
What happens on a system with no charliecloud module.
Is this persistent?
There was a problem hiding this comment.
- The only impact this will have on the current process it that the charliecloud executables will be in it's path if the module exists.
- If a system does not contain a charliecloud module, nothing will happen this will just throw an error.
- This is not persistent. It only applies to the beeflow process. If the beeflow process is killed such as with beeflow stop, a system restart, or a beeflow restart it will need to be loaded again.
I'll add an additional check to make sure lmod is on the system. It will work either way, but it's kind of silly to attempt to run an application that isn't installed.
|
I tried this on fog and it gives me this error: |
pagrubel
requested changes
Sep 6, 2023
pagrubel
approved these changes
Sep 11, 2023
jtronge
reviewed
Sep 19, 2023
beeflow/cli.py
Outdated
| def load_charliecloud(): | ||
| """Load the charliecloud module if it exists.""" | ||
| lmod = os.environ.get('MODULESHOME') | ||
| from env_modules_python import module #noqa No need to import at top |
There was a problem hiding this comment.
I'm getting a ModuleNotFoundError: No module named 'env_modules_python' on running beeflow start.
pagrubel
requested changes
Sep 22, 2023
pagrubel
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #580.