Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment charliecloud minimum version to include podman fix #723

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

rstyd
Copy link
Collaborator

@rstyd rstyd commented Sep 14, 2023

This issue updates the minimum version of charliecloud.

@rstyd rstyd requested a review from pagrubel September 14, 2023 16:55
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstyd The ci test needs to install the correct version so changes to ci/deps_install.sh are needed.
Also, the documentation also needs a correction in docs/sphinx/installation.rst

@rstyd rstyd changed the title Incrememnt charliecloud minimum version to include podman fix Increment charliecloud minimum version to include podman fix Sep 18, 2023
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks good!

@pagrubel pagrubel merged commit cd12c1a into develop Sep 22, 2023
4 checks passed
@pagrubel pagrubel deleted the update_charliecloud_version branch September 22, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants