Fix Checkpoint/Restart #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagrubel
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
In addition to the test's now passing, I ran the long checkpoint/restart test for clamr which failed since the max number of retries was set at 3 in my bee.conf. The only concern I have is that the only indication as to what happened is in the wf_manager log. We definitely need something in the query to inform us about what happened, bu t that would be a separate issue. Also, the integration tests also failed for me due to an issue with not having any anonymous pulls left, again the issue can be found by examining the logs.
Thanks for fixing the checkpoint/restart issue @Boogie3D & @jtronge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steven's fixes for checkpoint/restart, addressing issue #750.
After multiple restarts of a task that exceeds
num_tries, the workflow should be put in aFailedstate. I'm not sure if this should be theArchivedstate instead, which I think happens with other workflows?The checkpoint-restart tests can be run locally, after starting beeflow, with
./ci/integration_test.py -t checkpoint_restart_failure,checkpoint_restart --timeout 10000(this might take >10 minutes).