-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export dag #909
Export dag #909
Conversation
The changes in commit 2e284d1 is what made the "NOT_RESPONDING" state appear the other day. I'll test this again. |
I tested it again and the "NOT_RESPONDING" state didn't appear. |
Thank you this is much easier to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work, thanks Leah.
One last thing I'd like to see (besides the other changes I noted) before putting my final stamp of approval is an addition to our beeflow client documentation, since this change adds a new command to the client.
generate_graph.py
Outdated
|
||
if __name__ == "__main__": | ||
# Path to your GraphML file | ||
graphml_file = '/vast/home/leahh/.beeflow/dags/bebd6f.graphml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this user specific path, and replace it with a generic path for this PR.
@Leahh02 uses an augmented neo4j container for this capability. I'd like to see the Dockerfile for it in our repo to have a record of what to build. We will also need to fix the dependency build to use that, but that can be done in another PR. |
The clamr graph doesn't work, I'm trying to figure out why. I forgot to test it. |
I can create a dag when I have submitted the workflow with the no-start flag, but once I've started the workflow I can't make the graph anymore. The graphml file gets created but there's problems with networkx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I made sure Andres's change requests were in this PR. I tested this and will run our local overnight tests, upon those passing I'll approve and merge.
I checked his requests and they have been done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you @Leahh02
This is my work from the visualize-day branch, but it's now coming off of develop.
The goal is to export a dag as a graphml so it can be used by visualization tool.