-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue943/pull deps neo4j #945
base: develop
Are you sure you want to change the base?
Conversation
Leahh02
commented
Oct 10, 2024
•
edited
Loading
edited
- beeflow core pull-deps should use a Dockerfile to build the needed neo4j container and add the apoc file
- This dockerfile should be placed in beeflow/data/dockerfiles and should be used by the ci integration tests so we only need to modify it in one place.
- Also, if a user uses "beeflow core pull-deps" to have their own dependent containers, they should be used in the bee.conf file. Consider automatically editting it and removing the ~/.beeflow/deps directory. Beeflow should not be running when this is done, so adding a check for that should probably be done.
I'm working on the last part right now. I can change the name of beeflow/data/dockerfiles/Dockerfile.apoc_neo4j if needed. I can also remove beeflow/data/dockerfiles/Dockerfile.neo4j-ppc64le if needed. |
Yes, I think Dockerfile.neo4j would suffice and yes please remove the other. We will need to probably add one for arm architecture in the future. |