refactoring LightBulb_functions #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari2895
changed the title
curiousmiah
reviewed
Jan 5, 2024
mari2895
changed the title
curiousmiah
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Mariam, thank you for taking the lead on making these changes to the lightbulb algorithm. I looked over each of the files, and they look good to me. But then again, I was mostly looking over them to learn. Rather than approving merging, I'll just comment. I'll let Jonah give the final approval for merge.
Yurlungur
requested changes
Jan 17, 2024
src/phoebus_driver.cpp
Outdated
| const int num_partitions = pmesh->DefaultNumPartitions(); | ||
| TaskRegion &sync_region_lb = tc.AddRegion(num_partitions); | ||
| for (int ib = 0; ib < num_partitions; ++ib) { | ||
| auto &base = pmesh->mesh_data.GetOrAdd("base", ib); |
There was a problem hiding this comment.
Probably don't need to pull out base explicitly. Just use sc0.
There was a problem hiding this comment.
removed this line
Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
Yurlungur
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
scripts/bash/format.sh.