Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update singularity-eos and singularity-opac #199

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Update singularity-eos and singularity-opac #199

merged 5 commits into from
Feb 12, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

This is only tested locally on my machine. @AstroBarker @mari2895 please check it works everywhere relevant, e.g., Chicoma.

Also, I currently point the singularity-eos submodule at this branch. It needs to be updated once that PR goes through.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by calling scripts/bash/format.sh.
  • Explain what you did.

@Yurlungur Yurlungur added enhancement New feature or request help wanted Extra attention is needed labels Feb 11, 2024
@Yurlungur Yurlungur self-assigned this Feb 11, 2024
@AstroBarker
Copy link
Collaborator

Confirmed to build locally but seems to fail on Chicoma -- cmake could not locate the required hdf5 libraries in singularity.

@mari2895
Copy link
Collaborator

Confirmed to build locally but seems to fail on Chicoma -- cmake could not locate the required hdf5 libraries in singularity.

Builds locally for me too.

@Yurlungur
Copy link
Collaborator Author

@AstroBarker @mari2895 this build appears to work with my instructions. Can you check for yourselves?

AstroBarker
AstroBarker approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@AstroBarker AstroBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now compiling and running successfully on Chicoma and locally.

mari2895
mari2895 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@mari2895 mari2895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiles and runs for me

@Yurlungur Yurlungur merged commit 00a390d into main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroBarker AstroBarker AstroBarker approved these changes

@mari2895 mari2895 mari2895 approved these changes

@brryan brryan Awaiting requested review from brryan

@hlim88 hlim88 Awaiting requested review from hlim88

Assignees

@Yurlungur Yurlungur

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yurlungur @AstroBarker @mari2895 @jonahm-LANL