-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
outputs for SN postprocessing: max density, M_gain, and Qdot_gain #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mari2895 this looks good, but I think it needs some revision. Please let me know if you're confused by any of the blow comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just two more nitpicks...
src/fluid/fluid.cpp
Outdated
@@ -207,6 +208,7 @@ std::shared_ptr<StateDescriptor> Initialize(ParameterInput *pin) { | |||
physics->AddField(p::entropy::name(), mprim_scalar); | |||
physics->AddField(p::cs::name(), mprim_scalar); | |||
physics->AddField(diag::ratio_divv_cs::name(), mprim_scalar); | |||
physics->AddField(diag::localization_function::name(), mprim_scalar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're not using the localization function right? Let's comment this out for now and only add it when we need it.
PR Summary
Created a reducer that only integrates in the gain region. Added the following outputs in history file: max density (central density, mass_gain and total net neutrino heating in the gain region).
PR Checklist
scripts/bash/format.sh
.