Add eos information to floors, misc UserWorkBeforeOutput fix #210
Conversation
src/fluid/fluid.cpp
Outdated
| auto MaxDensity = [](MeshData<Real> *md) { | ||
| return ReduceOneVar<Kokkos::Max<Real>>(md, fluid_prim::density::name(), 0); | ||
| }; | ||
|
|
||
| hst_vars.emplace_back(HistoryOutputVar(HstMax, MaxDensity, "maximum density")); |
There was a problem hiding this comment.
Looks like this branch might be out of date with main... double check you and @mari2895 are in sync so your PRs don't undo each other.
There was a problem hiding this comment.
Looks like this is the same as current main, unless I missed something.
There was a problem hiding this comment.
Why is there a diff showing here then? Odd.
There was a problem hiding this comment.
Oh I see it now... not sure why it's different from main, don't think I did this myself..
There was a problem hiding this comment.
maybe just merge main in again... see if that fixes it?
There was a problem hiding this comment.
@AstroBarker Looks the same on my branch too. Don't see anything different.
There was a problem hiding this comment.
but why is it deleted? should not be deleted
|
Ready for re-review, @AstroBarker ? |
AstroBarker
changed the title
Good to go |
AstroBarker
added
bug
src/fluid/fluid.cpp
Outdated
| auto MaxDensity = [](MeshData<Real> *md) { | ||
| return ReduceOneVar<Kokkos::Max<Real>>(md, fluid_prim::density::name(), 0); | ||
| }; | ||
|
|
||
| hst_vars.emplace_back(HistoryOutputVar(HstMax, MaxDensity, "maximum density")); |
There was a problem hiding this comment.
Why is there a diff showing here then? Odd.
This PR adds knowledge of eos bounds to the floors. Specifically, for tabulated EOS, demand that the floors do not extrapolate off of the table. This required making the
boundsparam mutable.Currently, for ideal gas, the option to enforce user set bounds is supported by supplying, e.g.,
<eos>/rho_minin the input deck. If unspecified, reasonable defaults are set.Also fixed a misc bug in the
UserWorkBeforeOutputcode where a package and param were pulled out inside a device kernel that caused a crash on device.