Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on Frontier: update singularity, relocatable device code, misc fixes #218

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

AstroBarker
Copy link
Collaborator

This PR incorporates changes I needed to make to run on Frontier, plus some misc fixes:

  • Update singularity-eos to main
  • Move energy_from_rho_P from pgen.cpp into the header file.
  • The mckinnie_gammie_ryan constructor had a bug in a variable name
  • eos_phoebus.cpp had an incorrect redefinition of the lambda array that the compiler interpreted as an out of bounds array access
  • In the sedov pgen, the boolean to use spherical coords was loaded from input with GetOrAddReal

@AstroBarker AstroBarker added the bug Something isn't working label Oct 14, 2024
@AstroBarker AstroBarker added the enhancement New feature or request label Oct 14, 2024
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! How bad are compile times?

src/pgen/pgen.hpp Outdated Show resolved Hide resolved
@AstroBarker
Copy link
Collaborator Author

Thanks for the fixes! How bad are compile times?

Not speedy but not miserable -- I've seen much worse on chicoma

@Yurlungur
Copy link
Collaborator

Also looks like format tests are failing :)

@AstroBarker AstroBarker merged commit 157a790 into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants