Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abs function #275

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix abs function #275

merged 2 commits into from
Sep 22, 2023

Conversation

jeanlucf22
Copy link
Collaborator

@jeanlucf22 jeanlucf22 commented Sep 15, 2023

Issue reported by Jamal


This change is Reviewable

@jeanlucf22
Copy link
Collaborator Author

@ares201005 It looks like the test now fails when using the proper 'abs' function. Shall we loosen the tolerance?

Issue reported by Jamal
@jeanlucf22
Copy link
Collaborator Author

@ares201005 It looks like the test now fails when using the proper 'abs' function. Shall we loosen the tolerance?

@ares201005 Any comment?

@ares201005
Copy link
Collaborator

@ares201005 It looks like the test now fails when using the proper 'abs' function. Shall we loosen the tolerance?

@ares201005 Any comment?

Yes, I think we can loosen the tolerance. I am checking what's the proper tolerance.

@ares201005
Copy link
Collaborator

I found the issue comes from a but in prg_build_density_T_fermi_c where the drho value is passed to Fortran instead of reference so that the updated value in Fortran code is not passed back to C. Can I directly push my changes into your fabs branch? Otherwise I can make a separate PR as well.

@jeanlucf22
Copy link
Collaborator Author

I found the issue comes from a but in prg_build_density_T_fermi_c where the drho value is passed to Fortran instead of reference so that the updated value in Fortran code is not passed back to C. Can I directly push my changes into your fabs branch? Otherwise I can make a separate PR as well.

Thanks @ares201005 , looks good now

@nicolasbock nicolasbock merged commit 688c9b6 into lanl:master Sep 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants