Modifications for Cray build #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suemni
approved these changes
Nov 30, 2023
jeanlucf22
reviewed
Nov 30, 2023
| @@ -28,6 +28,10 @@ program hmodel | |||
| real(dp) :: ef,sparsity,dec,mlsi,mlsf,bnorm | |||
| character(20) :: bml_dmode | |||
|
|
|||
| #ifdef CRAY_SDK | |||
There was a problem hiding this comment.
Is it not correct to always define iargc as an integer?
CMakeLists.txt
Outdated
| @@ -36,7 +36,7 @@ add_definitions(-DPROGRESS_VERSION=${PROGRESS_VERSION}) | |||
| message(STATUS "Setting PROGRESS_VERSION to '${PROGRESS_VERSION}'") | |||
|
|
|||
| if(CMAKE_Fortran_COMPILER_ID STREQUAL "Cray") | |||
| set(EXTRA_FCFLAGS "-ef ${EXTRA_FCFLAGS}") | |||
| set(EXTRA_FCFLAGS "-ef -DCRAY_SDK ${EXTRA_FCFLAGS}") | |||
There was a problem hiding this comment.
we should do that in build script, not here
|
Maybe a better way is to add a build option to build with or without C interface, instead of building two libraries? |
o Add "integer argc" to benchmarks o Disable testing and example builds in crusher script o Include prg_c_interface conditionally in progress library o Fix lint issues
|
Yes, I actually ran into problems with dependencies when making this change. I backed it out and included prg_c_interface conditional on not Cray.
I think the declaration of iargc as integer should be OK whatever the compiler. I'll remove the macro.
…________________________________
From: Jean-Luc Fattebert ***@***.***>
Sent: Thursday, November 30, 2023 9:58 AM
To: lanl/qmd-progress ***@***.***>
Cc: Wall, Michael E ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [lanl/qmd-progress] Modifications for Cray build (PR #283)
Maybe a better way is to add a build option to build with or without C interface, instead of building two libraries?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/lanl/qmd-progress/pull/283*issuecomment-1834166353__;Iw!!Bt8fGhp8LhKGRg!GDJFqpQwiUVuAXKF_nrYPA14CR0Rd_BxmHpxGmkRFN5n7HDbe1JYla20Did8i-S4xJv9kITZ4XmY4MCVOJWHGaFY$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA67VEONMRDFH7AEBFWOYPTYHC3KDAVCNFSM6AAAAABABNLOPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGE3DMMZVGM__;!!Bt8fGhp8LhKGRg!GDJFqpQwiUVuAXKF_nrYPA14CR0Rd_BxmHpxGmkRFN5n7HDbe1JYla20Did8i-S4xJv9kITZ4XmY4MCVOL8byDfV$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jeanlucf22
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o Add CRAY_SDK macro
o Add "integer argc" to benchmarks, depending on CRAY_SDK
o Disable testing and example builds in crusher script
o Put prg_c_interface in new progress_c library
o Only build progress_c if not Cray compiler
This change is