Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the setting of SameSite property for CookieTest #57

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

rgriffogoes
Copy link

Fixing the issue where the cookie test SameSite was set to None only if the MellonCookieSameSite was set to something other than default instead of regardless of the value (as said in main page)

Addresses #20 and likely #47

get SameSite=None regardless of samesite setting, unless samesite
property is disabled.

Addresses latchset#20 and likely latchset#47
Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jhrozek jhrozek merged commit 5a629a1 into latchset:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants