Replace snippet placeholder when deleting last snippet #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tried to reduce some of the differences in naming and arguments between snippet nodes and snippet placeholders while doing this, so it's easier to do other work that pulls them together in the future but without re-writing everything. Also fixes commas in snippet list names.
Should be backwards compatible but does (can) not fix some historical issues that will remain in old documents. Namely:
,
in the name will remain broken. There's no reasonable way for us to figure out that this has happened, so we just handle it as before.connected issues and PRs:
Jira ticket: https://binnenland.atlassian.net/browse/GN-5003
Setup
N/A
How to test/reproduce
Create a document with placeholders, multi-snippet placeholders and placeholders with commas in the list names and play around inserting and deleting snippets and refreshing.
Challenges/uncertainties
N/A
Checks PR readiness