Fix issues related to equals
method defined on RDF term instances
#1200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes some changes in how the
equals
method/property is defined on RDF term instances.It defines
equals
as a prototype method on RDF term instances instead of as arrow functions.This has two implications:
equals
function is no longer defined on RDF term instances themselves, but rather on their prototype.equals
method.connected issues and PRs:
None
How to test/reproduce
functions are not supported
error message no longer shows up.equals
properties.Challenges/uncertainties
The change/rollback included in this PR does have some (possibly unwanted) side-effects:
equals
method. Typescript tries to handle this in the best way possible, but may sometimes make mistakes. An example can be found on Typescript playgroundOther possible approaches:
equals
functions. This does have the drawback that we cannot leverage the RDFJS interfaces.Checks PR readiness