Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign link to have coherent pills #1225

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Nov 6, 2024

Overview

Redesign the links to have a coherent style with the variable pills from the plugins

connected issues and PRs:

GN-5121

Setup

None

How to test/reproduce

Insert a link an check if the design matches the figma
https://www.figma.com/design/tfBSv7999dzz1sy6svMfsY/GN_editor?node-id=81-575&node-type=frame&t=heaVowawbkSrqvag-0

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant