Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require phone_number when verify sms code #555

Merged
merged 13 commits into from
Apr 7, 2024
Merged

Conversation

juvenn
Copy link
Member

@juvenn juvenn commented Mar 29, 2024

短信验证的时候,需要传递手机号

@juvenn
Copy link
Member Author

juvenn commented Apr 2, 2024

记录一下在挽救 CI 过程中遇到的不兼容问题。

python 3.12 开始移除了 imp ,而 nosetests 仍然依赖它。nose 本身也不再被维护了,推荐 pytest 。

 Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.2/x64/bin/nosetests", line 5, in <module>
    from nose import run_exit
  File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/nose/__init__.py", line 1, in <module>
    from nose.core import collector, main, run, run_exit, runmodule
  File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/nose/core.py", line 12, in <module>
    from nose.loader import defaultTestLoader
  File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/nose/loader.py", line 21, in <module>
    from nose.importer import Importer, add_path, remove_path
  File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/nose/importer.py", line 12, in <module>
    from imp import find_module, load_module, acquire_lock, release_lock
ModuleNotFoundError: No module named 'imp'

@juvenn
Copy link
Member Author

juvenn commented Apr 2, 2024

requests 2.30.0 升级了 urllib3 ,在 python 3.9 中会出现 wsgi init 错误

    WSGI_HTTPSConnection.__init__(self, *args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'cert_reqs'

@juvenn
Copy link
Member Author

juvenn commented Apr 2, 2024

python 3.11 nose 会报错

  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/nose/suite.py", line 106, in _set_tests
    if isinstance(tests, collections.Callable) and not is_suite:
                         ^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'collections' has no attribute 'Callable'

@juvenn
Copy link
Member Author

juvenn commented Apr 2, 2024

迁移到 pytest 的话需要 python 3.8+

@juvenn juvenn merged commit 483e3b3 into master Apr 7, 2024
6 checks passed
@juvenn juvenn deleted the fix/verify-sms branch April 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant