chore: use text variant of ✝︎ #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomeata
reviewed
Aug 28, 2024
| @@ -18,7 +18,7 @@ import { useEvent } from './util' | |||
|
|
|||
| /** Returns true if `h` is inaccessible according to Lean's default name rendering. */ | |||
| function isInaccessibleName(h: string): boolean { | |||
| return h.indexOf('✝') >= 0 | |||
| return h.indexOf('✝︎') >= 0 | |||
There was a problem hiding this comment.
Is this expected to work with previous versions of lean as well? Then maybe leave code as it (matches both) and leave a comment
There was a problem hiding this comment.
Yes, vscode-lean4 needs to be backwards compatible with all prior Lean 4 releases.
There was a problem hiding this comment.
ofc that was an oversight!
Anyways, I closed leanprover/lean4#5174 as I can't say with certainty that it won't introduce maintaince burden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following leanprover/lean4#5174 use text-variant selector for ✝︎.