Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] connecting to a robot twice results in a non-ready state #119

Closed
sverben opened this issue Aug 26, 2024 · 0 comments · Fixed by #131
Closed

[bug] connecting to a robot twice results in a non-ready state #119

sverben opened this issue Aug 26, 2024 · 0 comments · Fixed by #131
Assignees

Comments

@sverben
Copy link
Member

sverben commented Aug 26, 2024

When selecting the connect button in the header twice for the same robot without disconnecting, this will result in a non-ready state due to the port's streams already being locked

It would be nice to check for the following 2 scenarios

  1. The cause of the failed connect is that the same robot is already connected
  • We should probably immediately throw a ready state or trigger a reconnect by reserving the old port
  1. The cause of the failed connect is that another program is already using it
  • Instead of simply throwing a non-ready state and keeping the user guessing as to what went wrong we may want to show a popup to indicate the reason for the failed action
@leaphy-robotics leaphy-robotics deleted a comment Aug 26, 2024
@leaphy-robotics leaphy-robotics deleted a comment Aug 26, 2024
@sverben sverben self-assigned this Oct 7, 2024
@sverben sverben linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant