Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add feedback for errors and fix some misc issues #131

Merged
merged 10 commits into from
Oct 7, 2024
Merged

chore: add feedback for errors and fix some misc issues #131

merged 10 commits into from
Oct 7, 2024

Conversation

sverben
Copy link
Member

@sverben sverben commented Oct 7, 2024

This pr includes:

  • The removal for the robot selector in all environments but the cpp environment
  • Error feedback in several places (invalid project, invalid project filename, reserved port)
  • Fixes several errors by handling them with the previously stated feedback being shown to the user
  • Fixes the issue where pressing the connect button twice would cause the robot to enter an unusable state

@sverben sverben requested a review from a team as a code owner October 7, 2024 12:50
@sverben sverben linked an issue Oct 7, 2024 that may be closed by this pull request
[bug] connecting to a robot twice results in a non-ready state #119
Closed
rmoesbergen
rmoesbergen approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@rmoesbergen rmoesbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 spelfoutje, maar verder 👏👏

src/assets/translations/nl.json Outdated Show resolved Hide resolved
@sverben sverben merged commit a334f90 into main Oct 7, 2024
1 check passed
@sverben sverben deleted the error_feedback branch October 7, 2024 17:30
@rmoesbergen rmoesbergen mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoesbergen rmoesbergen rmoesbergen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] connecting to a robot twice results in a non-ready state
2 participants
@sverben @rmoesbergen