Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished mocked create renderer impl and first test cases #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robpatriot
Copy link
Collaborator

A few thoughts here:

  1. I used mocks for the dir for the fake vertex only impl of createmeshrenderer and put them in the mocks package. Maybe we want to keep these separate from actual gomock mocks? Either gologo_mocks or maybe some other non mocks based naming
  2. The opengl mocks file is called that because it uses the concrete definition of MeshRenderer. It also needs to return a MeshRenderer to pass to InitFromRenderer. Therefore I think this is reasonable but then I guess it breaks our idea of mocks because it depends on the very thing it's trying to "mock"

@leedenison
Copy link
Owner

I think this is fine. But maybe call it a fake rather than a mock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants