feat(s3): allow custom endpoint #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopadz
suggested changes
Oct 10, 2021
nipeharefa
force-pushed
the
test/custome-endpoint
branch
2 times, most recently
from
324720b
to
09b19e1
Compare
|
@nipeharefa could you please update the docs with some examples? cheers! |
nipeharefa
force-pushed
the
test/custome-endpoint
branch
from
09b19e1
to
86ce265
Compare
nipeharefa
force-pushed
the
test/custome-endpoint
branch
from
86ce265
to
1c6b658
Compare
|
Hello, @brunopadz just update the docs with some example with custom endpoint |
|
LGTM 👍 @amendoa could you please take a look into it? |
brunopadz
previously approved these changes
Nov 2, 2021
|
Anything else left before this can be merged? |
|
@Sytten I'm not a mantainer of this project anymore. You have to check with the new mantainers. Otherwise, feel free to fork the project and apply the changes. ;) |
|
@amendoa how is the review going for this? I think it could bring a very good impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @brunopadz
this is my first PR and just fix issue #17 to allow custom endpoint