feat(gargantuan): clean engine exit via ProcessService - #27
Merged
Conversation
After the done marker the head asks the engine to exit itself with ProcessService:ExitAsync(0), pcall-guarded twice over: older engines throw on GetService, and the current engine's ExitAsync raises due to an upstream argument-index bug. The CLI grace-waits three seconds for a clean exit before falling back to the kill; the padding loop stays for engines where the exit is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the done marker the head asks the engine to exit itself with ProcessService:ExitAsync(0), pcall-guarded twice over: older engines throw on GetService, and the current engine's ExitAsync raises due to an upstream argument-index bug. The CLI grace-waits three seconds for a clean exit before falling back to the kill; the padding loop stays for engines where the exit is unavailable.