feat(core)!: focus and skip modifiers, replacing xit - #31
Merged
Conversation
it and describe become callable tables carrying it.only, it.skip, it.todo, describe.only and describe.skip, so the destructuring line at the top of a spec keeps working. Focus resolves per run without mutating the registry: skip beats focus, the name filter narrows first, and focus only engages when a focused test would actually execute, so a bodyless or skipped .only cannot silence a file. test_skip gains focusExcluded and run_end gains focusUsed, both additive on protocol v1. --forbid-only fails the run when a focus modifier is committed. BREAKING CHANGE: xit is removed. it.skip replaces it with the same signature, so migrating is a rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it and describe become callable tables carrying it.only, it.skip, it.todo, describe.only and describe.skip, so the destructuring line at the top of a spec keeps working. Focus resolves per run without mutating the registry: skip beats focus, the name filter narrows first, and focus only engages when a focused test would actually execute, so a bodyless or skipped .only cannot silence a file. test_skip gains focusExcluded and run_end gains focusUsed, both additive on protocol v1. --forbid-only fails the run when a focus modifier is committed.
BREAKING CHANGE: xit is removed. it.skip replaces it with the same signature, so migrating is a rename.