Custom elliptic curve example #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that with the current code at 24daab5 we can't convert from jwk.Key to raw key back, especially when we are reusing one of the pre-existing keys. In order to make the round-trip work, we need to be able to inject custom heuristics code in the Raw() method of each object. |
|
I think this is ready minus some documentation fixes and possible ironing out of some details (TODO: apply same fixes to OKP, RSA, and symmetric keys) |
|
I don't like the naming. Perhaps JR -> Export, RJ -> Import |
Remove Raw() from keys, and implement jwk.Export
|
For the record, at this point I think at least 80% of the code works. I'm still missing tests/checks for OKP keys. |
|
Alright, it's about time. Going to merge to develop/v3 |
lestrrat
added a commit
that referenced
this pull request
Dec 6, 2023
* Add an example adding new EC algo and key type * Add failing example * Kind of fix, but still need to review spec * Appease linter * Add more context for debugging * fix directive * See if bumping go version to 1.21 only makes a difference * fix one more * Rename RJ/JR to Import/Export * fix usage * docs * oops, add missing file * Streamline exporting from jwk.Key to raw key Remove Raw() from keys, and implement jwk.Export * fix typo * appease linter * fix type detection for symmetric keys * rework OKP tests so that crypto/ecdh keys are tested * fix handling of x25519 keys * tweak * tweak docs * gofmt
lestrrat
added a commit
that referenced
this pull request
Jan 11, 2024
* Add an example adding new EC algo and key type * Add failing example * Kind of fix, but still need to review spec * Appease linter * Add more context for debugging * fix directive * See if bumping go version to 1.21 only makes a difference * fix one more * Rename RJ/JR to Import/Export * fix usage * docs * oops, add missing file * Streamline exporting from jwk.Key to raw key Remove Raw() from keys, and implement jwk.Export * fix typo * appease linter * fix type detection for symmetric keys * rework OKP tests so that crypto/ecdh keys are tested * fix handling of x25519 keys * tweak * tweak docs * gofmt
lestrrat
added a commit
that referenced
this pull request
Feb 19, 2024
* Add an example adding new EC algo and key type * Add failing example * Kind of fix, but still need to review spec * Appease linter * Add more context for debugging * fix directive * See if bumping go version to 1.21 only makes a difference * fix one more * Rename RJ/JR to Import/Export * fix usage * docs * oops, add missing file * Streamline exporting from jwk.Key to raw key Remove Raw() from keys, and implement jwk.Export * fix typo * appease linter * fix type detection for symmetric keys * rework OKP tests so that crypto/ecdh keys are tested * fix handling of x25519 keys * tweak * tweak docs * gofmt
lestrrat
added a commit
that referenced
this pull request
Mar 9, 2024
* Add an example adding new EC algo and key type * Add failing example * Kind of fix, but still need to review spec * Appease linter * Add more context for debugging * fix directive * See if bumping go version to 1.21 only makes a difference * fix one more * Rename RJ/JR to Import/Export * fix usage * docs * oops, add missing file * Streamline exporting from jwk.Key to raw key Remove Raw() from keys, and implement jwk.Export * fix typo * appease linter * fix type detection for symmetric keys * rework OKP tests so that crypto/ecdh keys are tested * fix handling of x25519 keys * tweak * tweak docs * gofmt
lestrrat
added a commit
that referenced
this pull request
Sep 24, 2024
* Add an example adding new EC algo and key type * Add failing example * Kind of fix, but still need to review spec * Appease linter * Add more context for debugging * fix directive * See if bumping go version to 1.21 only makes a difference * fix one more * Rename RJ/JR to Import/Export * fix usage * docs * oops, add missing file * Streamline exporting from jwk.Key to raw key Remove Raw() from keys, and implement jwk.Export * fix typo * appease linter * fix type detection for symmetric keys * rework OKP tests so that crypto/ecdh keys are tested * fix handling of x25519 keys * tweak * tweak docs * gofmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.