Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jws.WithHeaders #1163

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Deprecate jws.WithHeaders #1163

merged 1 commit into from
Jul 27, 2024

Conversation

lestrrat
Copy link
Collaborator

@lestrrat lestrrat commented Jul 27, 2024

The option never worked since v2, but it was kept around, and the documentation sometimes refered to this option, which it shouldn't have.

fixes #1153

The option never worked since v2, but it was kept around, and the
documentation sometimes refered to this option, which it shouldn't have.
@lestrrat lestrrat merged commit ccef636 into develop/v2 Jul 27, 2024
34 checks passed
@lestrrat lestrrat deleted the deprecate-jws-headers branch July 27, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jws: the value of jws.WithHeaders is ignored in jws.Sign
1 participant