Enable yamllint empty-values rule

Notes:
ansible/ansible-lint#4305
https://ansible.readthedocs.io/projects/lint/rules/yaml/#yamllint-configuration
https://yamllint.readthedocs.io/en/stable/disable_with_comments.html
https://yamllint.readthedocs.io/en/latest/rules.html#module-yamllint.rules.empty_values
https://github.com/ansible/galaxy_collection/blob/f2a57a1807dd5adbb8e654f3bd5e125d7fad2205/roles/collection/defaults/main.yml#L25

.yamllint.yml

@@ -0,0 +1,9 @@
+---
+# This expands on the defaults provided by ansible-lint
+#   https://ansible.readthedocs.io/projects/lint/rules/yaml/#yamllint-configuration
+# We don't call yamllint directly, it's called through ansible-lint
+rules:
+  empty-values:
+    forbid-in-block-mappings: true
+    forbid-in-flow-mappings: true
+    forbid-in-block-sequences: true

ci/playbooks/architecture/validate-architecture.yml

@@ -161,7 +161,6 @@
         - "{{ cifmw_basedir }}/artifacts/ecdsa_deploy"
 
     - name: Generate needed facts out of local files
-      vars:
       ansible.builtin.set_fact:
         cifmw_ci_gen_kustomize_values_ssh_authorizedkeys: >-
           {{

ci/playbooks/crc/reconfigure-kubelet.yml

@@ -45,6 +45,7 @@
 
         - name: Reboot host after kubelet is reconfigured
           ansible.builtin.reboot:
+            msg: "Rebooting machine now"
 
     - include_role:
         name: start-zuul-console

playbooks/ceph.yml

@@ -316,7 +316,7 @@
         cidr: 64
 
     - name: Generate a cephx key
-      cephx_key:
+      cephx_key: # noqa: yaml[empty-values]
       register: cephx
       no_log: true
 
@@ -359,9 +359,9 @@
       loop: "{{ _target_hosts }}"
 
     # cifmw_cephadm_vip is the VIP reserved in the Storage network
-    - name: Set VIP var as empty string
+    - name: Set cifmw_cephadm_vip var to null
       ansible.builtin.set_fact:
-        cifmw_cephadm_vip: ""
+        cifmw_cephadm_vip: null
 
     - name: Process VIP
       ansible.builtin.include_role:

roles/build_containers/defaults/main.yml

@@ -33,7 +33,7 @@ cifmw_build_containers_registry_namespace: podified-master-centos9
 cifmw_build_containers_push_registry: quay.io
 cifmw_build_containers_hotfix_images: []
 cifmw_build_containers_hotfix_rpms_paths: []
-cifmw_build_containers_hotfix_tag: ""
+cifmw_build_containers_hotfix_tag: null
 cifmw_build_containers_run_hotfix: false
 cifmw_build_containers_volume_mounts:
   - "/usr/share/tcib/container-images:/usr/share/tcib/container-images:z"

roles/build_push_container/defaults/main.yml

@@ -22,7 +22,7 @@ cifmw_build_push_container_basedir: "{{ cifmw_basedir | default(ansible_user_dir
 cifmw_build_push_container_artifacts: "{{ (cifmw_build_push_container_basedir, 'artifacts', 'build_push_container')| ansible.builtin.path_join }}"
 
 # Build vars
-cifmw_build_push_container_name:
+cifmw_build_push_container_name: null
 cifmw_build_push_container_build_context_path: "{{ (ansible_user_dir, zuul.project.src_dir) | ansible.builtin.path_join }}"
 cifmw_build_push_container_containerfile_name: Containerfile
 cifmw_build_push_container_containerfile_path: >-
@@ -42,7 +42,7 @@ cifmw_build_push_container_patch_number: "{{ zuul.change }}"
 cifmw_build_push_container_tag_override: []
 # Push vars
 cifmw_build_push_container_push: false
-cifmw_build_push_container_registry_name:
-cifmw_build_push_container_registry_username:
-cifmw_build_push_container_registry_password:
+cifmw_build_push_container_registry_name: null
+cifmw_build_push_container_registry_username: null
+cifmw_build_push_container_registry_password: null
 cifmw_build_push_container_registry_tls_verify: true

roles/cert_manager/defaults/main.yml

@@ -48,7 +48,7 @@ cifmw_cert_manager_olm_subscription:
   kind: Subscription
   metadata:
     labels:
-      operators.coreos.com/openshift-cert-manager-operator.cert-manager-operator: ""
+      operators.coreos.com/openshift-cert-manager-operator.cert-manager-operator: null
     name: openshift-cert-manager-operator
     namespace: "{{ cifmw_cert_manager_operator_namespace }}"
   spec:

roles/ci_metallb/defaults/main.yml

@@ -53,4 +53,4 @@ cifmw_ci_metallb_operator_config:
   spec:
     logLevel: debug
     nodeSelector:
-      node-role.kubernetes.io/worker: ""
+      node-role.kubernetes.io/worker: null

roles/ci_nmstate/defaults/main.yml

@@ -39,7 +39,7 @@ cifmw_ci_nmstate_olm_subscription:
   kind: Subscription
   metadata:
     labels:
-      operators.coreos.com/kubernetes-nmstate-operator.openshift-nmstate: ""
+      operators.coreos.com/kubernetes-nmstate-operator.openshift-nmstate: null
     name: kubernetes-nmstate-operator
     namespace: "{{ cifmw_ci_nmstate_namespace }}"
   spec:
@@ -64,7 +64,7 @@ cifmw_ci_nmstate_nncp_config_template:
     desiredState:
       interfaces: {}
     nodeSelector:
-      node-role.kubernetes.io/worker: ""
+      node-role.kubernetes.io/worker: null
 
 cifmw_ci_nmstate_unmanaged_config_template: {}
 cifmw_ci_nmstate_instances_skip_list: []

roles/cifmw_ceph_spec/defaults/main.yml

@@ -25,7 +25,7 @@ cifmw_ceph_spec_host_to_ip:
 
 # The ceph spec data devices. Should be passed as a YAML multiline string.
 # Use the default from the cifmw_block_device role:
-cifmw_ceph_spec_data_devices:
+cifmw_ceph_spec_data_devices: null
 
 # The path of the rendered spec file
 cifmw_ceph_spec_path: /tmp/ceph_spec.yml

roles/cifmw_cephadm/defaults/main.yml

@@ -61,7 +61,7 @@ cifmw_cephadm_apply_ceph_conf_overrides_on_update: false
 cifmw_cephadm_standalone: false
 cifmw_cephadm_default_container: false
 cifmw_cephadm_single_host_defaults: false
-cifmw_cephadm_extra_args: ""
+cifmw_cephadm_extra_args: null
 cifmw_cephadm_pacific_filter: "16.*"
 # The path of the rendered rgw spec file
 cifmw_ceph_rgw_spec_path: /tmp/ceph_rgw.yml
@@ -90,8 +90,8 @@ cifmw_ceph_rgw_config:
   rgw_max_attr_size: 1024
 cifmw_cephadm_cephfs_name: "cephfs"
 cifmw_ceph_dashboard_spec_path: /tmp/ceph_dashboard.yml
-cifmw_cephadm_certificate: ""
-cifmw_cephadm_key: ""
+cifmw_cephadm_certificate: null
+cifmw_cephadm_key: null
 cifmw_cephadm_dashboard_port: 8444
 cifmw_cephadm_grafana_admin_user: 'admin'
 cifmw_cephadm_grafana_admin_password: '/home/grafana_password.yml'

roles/cifmw_external_dns/defaults/main.yml

@@ -14,7 +14,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-cifmw_external_dns_domain: ""
+cifmw_external_dns_domain: null
 cifmw_external_dns_name: "{{ cifmw_external_dns_domain | regex_replace('\\.','-')}}-dns"
 cifmw_external_dns_labels: {}
 cifmw_external_dns_cert_name: "{{ cifmw_external_dns_domain | regex_replace('\\.','-')}}-cert"
@@ -34,7 +34,7 @@ cifmw_external_dns_cert_issuer_duration: 43800h0m0s
 cifmw_external_dns_retries: 60
 cifmw_external_dns_delay: 10
 cifmw_external_dns_clean_cert: true
-cifmw_external_dns_masq_cluster_ip: ""
+cifmw_external_dns_masq_cluster_ip: null
 cifmw_external_dns_vip_ext: {}
 cifmw_external_dns_vip_int: {}
 cifmw_external_dns_extra_subj_alt_names: {}

roles/config_drive/defaults/main.yml

@@ -28,5 +28,5 @@ cifmw_config_drive_instancedir: "{{ cifmw_config_drive_workdir }}/{{ cifmw_confi
 cifmw_config_drive_iso_image: "{{ cifmw_config_drive_workdir }}/{{ cifmw_config_drive_uuid }}.iso"
 cifmw_config_drive_name: test
 cifmw_config_drive_hostname: test.example.com
-cifmw_config_drive_userdata:
-cifmw_config_drive_networkconfig:
+cifmw_config_drive_userdata: null
+cifmw_config_drive_networkconfig: null

roles/dlrn_promote/defaults/main.yml

@@ -21,8 +21,8 @@
 cifmw_dlrn_promote_workspace: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}"
 cifmw_dlrn_promote_dlrnapi_user: "{{ dlrnapi_user | default('review_rdoproject_org') }}"
 cifmw_dlrn_promote_kerberos_auth: false
-cifmw_dlrn_promote_dlrnapi_host_principal: ""
-cifmw_dlrn_promote_criteria_file: ""
+cifmw_dlrn_promote_dlrnapi_host_principal: null
+cifmw_dlrn_promote_criteria_file: null
 cifmw_dlrn_promote_hash: false
 cifmw_dlrn_promote_hash_promote_content: false
 cifmw_dlrn_promote_ssl_ca_bundle: "/etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt"

roles/dlrn_promote/tasks/check_for_previous_promotions.yml

@@ -2,7 +2,7 @@
 - name: Set empty value for dlrnapi password
   ansible.builtin.set_fact:
     dlrnapi:
-      password: ""
+      password: null
   when:
     - dlrnapi is defined
     - "'password' not in dlrnapi"

roles/dlrn_promote/tasks/check_reported_jobs.yml

@@ -2,7 +2,7 @@
 - name: Set empty value for dlrnapi password
   ansible.builtin.set_fact:
     dlrnapi:
-      password: ""
+      password: null
   when:
     - dlrnapi is defined
     - "'password' not in dlrnapi"

roles/dlrn_promote/tasks/promote_hash.yml

@@ -2,7 +2,7 @@
 - name: Set empty value for dlrnapi password
   ansible.builtin.set_fact:
     dlrnapi:
-      password: ""
+      password: null
   when:
     - dlrnapi is defined
     - "'password' not in dlrnapi"

roles/dlrn_report/defaults/main.yml

@@ -22,8 +22,8 @@ cifmw_dlrn_report_workspace: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci
 cifmw_dlrn_report_dlrnapi_user: "{{ dlrnapi_user | default('review_rdoproject_org') }}"
 cifmw_dlrn_report_kerberos_auth: false
 cifmw_dlrn_report_result: true
-cifmw_dlrn_report_dlrnapi_host_principal: ""
-cifmw_dlrn_report_keytab: ""
-cifmw_dlrn_report_krb_user_realm: ""
+cifmw_dlrn_report_dlrnapi_host_principal: null
+cifmw_dlrn_report_keytab: null
+cifmw_dlrn_report_krb_user_realm: null
 cifmw_dlrn_report_zuul_log_path: "https://logserver.rdoproject.org"
-cifmw_dlrn_report_promote_source: ""
+cifmw_dlrn_report_promote_source: null

roles/dlrn_report/tasks/dlrn_report_results.yml

@@ -25,7 +25,7 @@
 - name: Set empty value for dlrnapi password
   ansible.builtin.set_fact:
     dlrnapi:
-      password: ""
+      password: null
   when:
     - dlrnapi is defined
     - "'password' not in dlrnapi"

roles/dnsmasq/defaults/main.yml

@@ -20,7 +20,7 @@
 cifmw_dnsmasq_basedir: "/etc/cifmw-dnsmasq.d"
 cifmw_dnsmasq_dns_config_file: "{{ cifmw_dnsmasq_basedir }}/dns.conf"
 cifmw_dnsmasq_listener_config_file: "{{ cifmw_dnsmasq_basedir }}/listener.conf"
-cifmw_dnsmasq_raw_config: ""
+cifmw_dnsmasq_raw_config: null
 cifmw_dnsmasq_forwarders: []
 cifmw_dnsmasq_interfaces: []
 cifmw_dnsmasq_listen_addresses: []

roles/edpm_deploy/defaults/main.yml

@@ -29,6 +29,6 @@ cifmw_edpm_deploy_dryrun: false
 cifmw_edpm_deploy_timeout: 60
 cifmw_edpm_deploy_registry_url: "{{ cifmw_install_yamls_defaults['DATAPLANE_REGISTRY_URL'] }}"
 cifmw_edpm_deploy_prepare_run: true
-cifmw_edpm_deploy_nova_compute_extra_config: ""
+cifmw_edpm_deploy_nova_compute_extra_config: null
 # Defines the kind of resources that should be applied only in step 2 of the EDPM deployment
 cifmw_edpm_deploy_step2_kind: "OpenStackDataPlaneDeployment"

roles/edpm_prepare/tasks/main.yml

@@ -25,7 +25,7 @@
     operators_build_output: "{{ (cifmw_operator_build_output | default({'operators':{}})).operators }}"
   ansible.builtin.set_fact:
     _install_yamls_repos:
-      OPENSTACK_BRANCH: ""
+      OPENSTACK_BRANCH: null
       GIT_CLONE_OPTS': "-l"
       OPENSTACK_REPO': "{{ operators_build_output[cifmw_operator_build_meta_name].git_src_dir  }}"
 

roles/idrac_configuration/tasks/racreset.yml

@@ -22,3 +22,4 @@
 
 - name: Wait For iDRAC To Be Online (Using SSH)
   ansible.builtin.wait_for:
+    timeout: 300

roles/install_yamls/molecule/default/converge.yml

@@ -71,9 +71,9 @@
       vars:
         expected_output:
           OPENSTACK_REPO: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/openstack-operator"
-          OPENSTACK_BRANCH: ""
+          OPENSTACK_BRANCH: null
           BAREMETAL_REPO: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/openstack-baremetal-operator"
-          BAREMETAL_BRANCH: ""
+          BAREMETAL_BRANCH: null
       ansible.builtin.assert:
         that:
           - cifmw_install_yamls_operators_repo == expected_output

roles/install_yamls/tasks/zuul_set_operators_repo.yml

@@ -29,7 +29,7 @@
       - key: "{{ _repo_operator_name | upper }}_REPO"
         value: "{{ ansible_user_dir }}/{{ zuul_item.project.src_dir }}"
       - key: "{{ _repo_operator_name | upper }}_BRANCH"
-        value: ""
+        value: null
   ansible.builtin.set_fact:
     cifmw_install_yamls_operators_repo: "{{ cifmw_install_yamls_operators_repo | default({}) | combine(_repo_operator_info | items2dict) }}"
   loop: "{{ zuul['items'] }}"

roles/libvirt_manager/defaults/main.yml

@@ -48,7 +48,7 @@ cifmw_libvirt_manager_configuration:
 
 cifmw_libvirt_manager_crc_pool: "{{ cifmw_crc_pool | default(lookup('env', 'HOME')) ~ '/.crc/machines/crc' }}"
 cifmw_libvirt_manager_vol_prefix: ''
-cifmw_libvirt_manager_pool:
+cifmw_libvirt_manager_pool: null
 cifmw_libvirt_manager_pool_dir: "{{ cifmw_libvirt_manager_basedir }}/volumes"
 cifmw_libvirt_manager_ocp_pool: "ocp_volumes"
 cifmw_libvirt_manager_ocp_pool_dir: "{{ cifmw_libvirt_manager_basedir }}/ocp_volumes"

roles/nat64_appliance/files/elements/nat64-router/package-installs.yaml

@@ -1,3 +1,4 @@
+# TODO(Lewis): Need to find what this is for
 bind-utils:
 gcc:
 git:

roles/openshift_adm/defaults/main.yml

@@ -25,7 +25,7 @@ cifmw_openshift_adm_cert_expire_date_file: >-
     (cifmw_openshift_adm_basedir, 'artifacts', '.ocp_cert_not_after') |
     ansible.builtin.path_join
   }}
-cifmw_openshift_adm_op: ""
+cifmw_openshift_adm_op: null
 cifmw_openshift_adm_dry_run: false
 cifmw_openshift_adm_retry_count: 100
 cifmw_openshift_adm_stable_period: 3m

roles/openshift_adm/files/regenerate-certificate.yml

@@ -85,7 +85,7 @@ spec:
             - mountPath: /etc/kubernetes/
               name: kubelet-dir
       nodeSelector:
-        node-role.kubernetes.io/master: ""
+        node-role.kubernetes.io/master: null
       priorityClassName: "system-cluster-critical"
       restartPolicy: Always
       securityContext:

roles/openshift_obs/defaults/main.yml

@@ -22,7 +22,7 @@ cifmw_openshift_obs_definition:
     name: observability-operator
     namespace: openshift-operators
     labels:
-      operators.coreos.com/observability-operator.openshift-operators: ""
+      operators.coreos.com/observability-operator.openshift-operators: null
   spec:
     channel: development
     installPlanApproval: Automatic

roles/ovirt/defaults/main.yml

@@ -21,7 +21,7 @@
 cifmw_ovirt_artifacts_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}/artifacts"
 cifmw_ovirt_ssh_key_type: "{{ cifmw_ssh_keytype | default('ecdsa') }}"
 cifmw_ovirt_ssh_key_size: "{{ cifmw_ssh_keysize | default(521) }}"
-cifmw_ovirt_ssh_public_key: ""
+cifmw_ovirt_ssh_public_key: null
 cifmw_ovirt_vm_timeout: 300
 cifmw_ovirt_sdk_package: "https://github.com/oVirt/python-ovirt-engine-sdk4/releases/download/4.6.2/python3-ovirt-engine-sdk4-4.6.2-1.el9.x86_64.rpm"
 

roles/reportportal/defaults/main.yml

@@ -1,9 +1,9 @@
 ---
 cifmw_reportportal_dry_run: false
 cifmw_reportportal_basedir: "{{ cifmw_basedir | default(ansible_user_dir ~ '/ci-framework-data') }}"
-cifmw_reportportal_datarouter_url: ""
-cifmw_reportportal_datarouter_username: ""
-cifmw_reportportal_datarouter_password: ""
+cifmw_reportportal_datarouter_url: null
+cifmw_reportportal_datarouter_username: null
+cifmw_reportportal_datarouter_password: null
 cifmw_reportportal_droute_dir: >-
   {{
     (cifmw_reportportal_basedir,
@@ -34,9 +34,9 @@ cifmw_reportportal_results_search: >-
   }}
 cifmw_reportportal_droute_version: "1.2.1"
 cifmw_reportportal_droute_binary: "droute-linux-amd64"
-cifmw_reportportal_droute_client_url: ""
-cifmw_reportportal_instance: ""
-cifmw_reportportal_project: ""
+cifmw_reportportal_droute_client_url: null
+cifmw_reportportal_instance: null
+cifmw_reportportal_project: null
 cifmw_reportportal_property_filter:
   - ".*"
 cifmw_reportportal_launch_name: "Dummy launch"

roles/shiftstack/defaults/main.yml

@@ -27,7 +27,7 @@ cifmw_shiftstack_client_pvc_manifest: "{{ cifmw_shiftstack_client_pod_name }}_pv
 cifmw_shiftstack_cluster_name: "ostest"
 cifmw_shiftstack_installation_dir: "{{ cifmw_shiftstack_basedir }}/installation"
 cifmw_shiftstack_project_name: "shiftstack"
-cifmw_shiftstack_qa_gerrithub_change: ""
+cifmw_shiftstack_qa_gerrithub_change: null
 cifmw_shiftstack_qa_repo: "https://review.gerrithub.io/shiftstack/shiftstack-qa"
 cifmw_shiftstack_run_playbook: "ocp_testing.yaml"
 cifmw_shiftstack_sc: "local-storage"

roles/ssh_jumper/defaults/main.yml

@@ -19,9 +19,9 @@
 # All variables within this role should have a prefix of "cifmw_ssh_jumper"
 
 cifmw_ssh_jumper_config:
-  - hostname:
-    proxy_host:
-    identity_file:
+  - hostname: null
+    proxy_host: null
+    identity_file: null
     patterns: "{{ cifmw_ssh_jumper_defaults.patterns }}"
     target: "{{ cifmw_ssh_jumper_defaults.target }}"
     ssh_dir: "{{ cifmw_ssh_jumper_defaults.ssh_dir }}"

roles/switch_config/tasks/onyx_config.yml

@@ -1,6 +1,7 @@
 ---
 - name: Collect switch facts
   mellanox.onyx.onyx_facts:
+    gather_subset: version
   register: onyx_facts
   failed_when: false