Add support to net_map plugin for configuring Multus routes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
lewisdenny
commented
Jun 19, 2024
tests/unit/module_utils/test_files/networking-definition-valid-all-tools-dual-stack.yml
Outdated
Show resolved
Hide resolved
tests/unit/module_utils/test_files/networking-definition-valid-all-tools-full-map-out.json
Outdated
Show resolved
Hide resolved
pablintino
reviewed
Jun 19, 2024
lewisdenny
force-pushed
the
add_multus_route_support
branch
4 times, most recently
from
6321857
to
dee3a9f
Compare
This zone will allow to get fixed names to access utility services, such as the IPMI. Using names instead of IPs ensures we can easily inject IPv6 in the game, without having to chase down IPs in the code: just update the DNS record to get either IPv4, or IPv6, or even dual-stack. This patch also updates sushy_emulator role to remove some hacks injected as "quick workaround". The cifmw_sushy_emulator_listen_ip parameter is now passed as-is and, if needed, any IPv6 we really pass there would be properly wrapped. In the reproducer context, it will get a hostname instead, ensuring we pass via the .utility zone and appropriate records.
Use a variable for the branch when doing git checkout of devscripts. For exameple: cifmw_devscripts_repo: 'https://github.com/hjensas/dev-scripts.git' cifmw_devscripts_repo_branch: support-ipv6-connected
At the same time, fix a format issue in the Net Env Def that assumes the parent_interface is always present. That's no longer true since we added the new mapper that works in best effort mode.
lewisdenny
force-pushed
the
add_multus_route_support
branch
from
dee3a9f
to
0d17230
Compare
lewisdenny
force-pushed
the
add_multus_route_support
branch
from
0d17230
to
4a123c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pull request owner and reviewers, I checked that: