Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multiple PR Previews #70

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Support Multiple PR Previews #70

merged 7 commits into from
Mar 7, 2023

Conversation

Shaikh-Ubaid
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid commented Mar 7, 2023 •
edited
Loading

towards #67

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/70

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/70

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 7, 2023 06:50
@Shaikh-Ubaid
Copy link
Member Author

Shaikh-Ubaid commented Mar 7, 2023 •
edited
Loading

It seems to work after commit Create .nojekyll. The .nojekyll file needs to be in the root directory.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/70

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review March 7, 2023 12:21
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Your site is deployed at https://lfortran.github.io/pull_request_preview/lfortran/70

@Shaikh-Ubaid
Copy link
Member Author

This is ready. Please review and share feedback.

@Shaikh-Ubaid Shaikh-Ubaid requested a review from certik March 7, 2023 12:28
Shaikh-Ubaid
Shaikh-Ubaid commented Mar 7, 2023
View reviewed changes
utils/commit.json
@@ -0,0 +1 @@
{ "id": "c969e0bc3" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, we are now maintaining the latest_commit in this utils/commit.json file. (It is now separate from the build script).

@Shaikh-Ubaid
Copy link
Member Author

Currently, after a PR is closed/merged, its preview folder needs to be manually deleted. (Automatic deletion of the preview folder is yet to be supported.)

certik
certik approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. After you merge, can you please also document in the README what the process is to update LFortran?

@certik certik merged commit d66ddf2 into main Mar 7, 2023
@certik certik deleted the multiple_pr_previews branch March 7, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaikh-Ubaid @certik