Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix battery name add logging and uninstall #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix battery name add logging and uninstall #5

wants to merge 6 commits into from

Commits on Aug 19, 2023

  1. Use battery name generated from glob pattern instaed of hard coding t… 

    …he name.

Previously, the battery name was hard-coded to BAT1 which mightn't be the battery designation for every device, so using the battery name generated from glob pattern while opening the file charge_full.

Additionally, it can be further improved to collect separate data for each batteries in case of multiple batteries (if required).
    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    169df02 View commit details
    Browse the repository at this point in the history

  2. Copy the content of the local git repo for insallation. 

    - For development purposes, it mightn't be feasible to get root access to edit the files inside of /opt/batterylog which is the folder of installation to which every file got moved prior to this. So, instead of moving the whole repository keeping a local copy as to make it easier for development.

- Also adding log messages for installation as to debug installation errors (if any).

- Adding .sleep to the extension of batterylog script used pior to suspend
and after resuming to keep it consistent with other files in
/usr/lib/systemd/system-sleep/.
    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    aaf915c View commit details
    Browse the repository at this point in the history

  3. Add additional logging to make it easier to know if scripts are runni… 

    …ng properly.

- Use string 'pre' and 'post' for comparison to remove ambiguity in the comparison.
    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    41617ba View commit details
    Browse the repository at this point in the history

  4. Fix the indentation mistake.

    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    e73a5dc View commit details
    Browse the repository at this point in the history

  5. Add UNINSTALL.sh script for removing the added files. 

    Prior to this, user wouldn't totally know the location of added files as separate files are added to different locations, so to make it easier to properly remove the added files and restore the system to prior state, adding UNINSTALL.sh script.
    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    fcef347 View commit details
    Browse the repository at this point in the history

  6. Fix naming mistake.

    @earthPerson-001
    earthPerson-001 committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5ae7bba View commit details
    Browse the repository at this point in the history