Make within_segment more robust with a relative tolerance

libMesh · Nov 14, 2022 · e7276af · e7276af
1 parent 8248853
commit e7276af
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 42 deletions.
diff --git a/include/geom/intersection_tools.h b/include/geom/intersection_tools.h
@@ -41,22 +41,6 @@ enum WithinSegmentResult : int {
                          AT_END = 2,
                          BETWEEN = 3 };
 
-/**
- * Checks whether or not a point is within a line segment
- * @param s1 The first point on the segment
- * @param s2 The second point on the segment
- * @param length The segment length (for optimization if it's already computed)
- * @param p The point
- * @param tol The tolerance to use
- * @return Enum denoting whether or not the point is not within, at s1,
- * at s2, or between [s1, s2]
- */
-WithinSegmentResult within_segment(const Point & s1,
-                                   const Point & s2,
-                                   const Real length,
-                                   const Point & p,
-                                   const Real tol = TOLERANCE);
-
 /**
  * Checks whether or not a point is within a line segment
  * @param s1 The first point on the segment

diff --git a/src/geom/intersection_tools.C b/src/geom/intersection_tools.C
@@ -29,40 +29,33 @@ namespace libMesh::IntersectionTools
 
 WithinSegmentResult within_segment(const Point & s1,
                                    const Point & s2,
-                                   const Real length,
                                    const Point & p,
                                    const Real tol)
 {
-  libmesh_assert(!s1.absolute_fuzzy_equals(s2, tol));
-  libmesh_assert_less(std::abs((s1 - s2).norm() - length), tol);
+  libmesh_assert(!s1.relative_fuzzy_equals(s2, tol));
 
+  // First, check whether or not the points are collinear
+  const auto l = s1 - s2;
+  const auto l_norm = l.norm();
   const auto diff1 = p - s1;
-  const auto diff2 = p - s2;
-  const auto tol_scaled = tol * length;
-
-  if (diff1 * diff2 > tol_scaled)
-    return NOT_WITHIN;
-
   const auto diff1_norm = diff1.norm();
-  if (diff1_norm < tol_scaled)
-    return AT_BEGINNING;
-
-  const auto diff2_norm = diff2.norm();
-  if (diff2_norm < tol_scaled)
-    return AT_END;
+  if ((std::abs(l * diff1) / (l_norm * diff1_norm)) < ((Real)1 - tol))
+    return NOT_WITHIN;
 
-  // whether or not p is _between_ [s1, s2]
-  if (std::abs(diff1_norm + diff2_norm - length) < tol_scaled)
+  // If the points are collinear, make sure that p is
+  // somewhere between [s1, s2]
+  const auto diff2_norm = (p - s2).norm();
+  const auto tol_scaled = tol * l_norm;
+  if (std::abs(diff1_norm + diff2_norm - l_norm) < tol_scaled)
+  {
+    if (diff1_norm < tol_scaled)
+      return AT_BEGINNING;
+    if (diff2_norm < tol_scaled)
+      return AT_END;
     return BETWEEN;
-  return NOT_WITHIN;
-}
+  }
 
-WithinSegmentResult within_segment(const Point & s1,
-                                   const Point & s2,
-                                   const Point & p,
-                                   const Real tol)
-{
-  return within_segment(s1, s2, (s1 - s2).norm(), p, tol);
+  return NOT_WITHIN;
 }
 
 bool collinear(const Point & p1,

diff --git a/tests/geom/intersection_tools_test.C b/tests/geom/intersection_tools_test.C
@@ -47,7 +47,6 @@ public:
       else if (i == segments)
         within_result = IntersectionTools::WithinSegmentResult::AT_END;
 
-      CPPUNIT_ASSERT_EQUAL(IntersectionTools::within_segment(s1, s2, length, p), within_result);
       CPPUNIT_ASSERT_EQUAL(IntersectionTools::within_segment(s1, s2, p), within_result);
     }