Fix access violation error on Win64 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@alecjacobson @jdumas hey guys possible to get this merged? |
|
Honestly I want to drop support for Cork from libigl, due to its problematic dependencies. Cork shouldn't include its own version of |
|
ah, thanks for the info. I'm working on dependencies for @qnzhou PyMesh/PyMesh#302 and I saw your comments on the 3.0.0 cmake rebuild and so have skipped it for now. |
|
I don't think @qnzhou has a lot of bandwidth to work on PyMesh these days. I would love to see PyMesh packaged with conda, but with all the dependencies it would be a lot of work... |
|
Yep, I'm slowly chipping away at it though its probably more work than I realise... good ole dunning-kruger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue libigl/libigl#1548
See also https://stackoverflow.com/questions/44558793/triangle-library-with-vs2015-x64/48230910#48230910