-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(swarm): Remove deprecated functions #3170
chore(swarm): Remove deprecated functions #3170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hannes, looks good on my end! Only the CHANGELOG.md
's changes are missing, check here for an example. Btw why is clippy complaining?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK modulo a changelog entry.
/// [`ThreadPool`](futures::executor::ThreadPool). | ||
#[deprecated(since = "0.41.0", note = "Use `SwarmBuilder::with_executor` instead.")] | ||
pub fn executor(mut self, executor: Box<dyn Executor + Send>) -> Self { | ||
self.pool_config = self.pool_config.with_executor(executor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_executor
is unused now I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so let's just delete it then
Before we can merge this, we need to fix the integration test here: https://github.com/libp2p/test-plans/blob/master/ping/rust/src/bin/testplan_0500.rs#L15 Would you mind sending a PR for that? |
On it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @umgefahren for the help here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umgefahren can you address the CI failures in libp2p
and libp2p-gossipsub
?
Yes will do. Although tomorrow |
Took a little longer, my bad. Should be working now. |
Thanks for the follow-ups!
Missing changelog entry @umgefahren. Can you add one? |
|
I forgot to bump the dependents of |
Just to make sure my mental model is correct, cargo semver check could not have detected the above, right? //CC @thomaseizinger |
I think it could but it doesn't today. cc @obi1kenobi This might be an interesting rule to add:
|
Great idea, thank you! Added to obi1kenobi/cargo-semver-checks#5 |
Damn that is a long list! Looking forward to having all those automated some day :) |
It's not even a complete list, turns out there are lots of ways to break semver in Rust 😅 We just merged a big revamp of how our tests are structured, so we can start knocking out more items from the list pretty soon. Some items are blocked on needing new schema (generics, lifetimes, trait bounds, etc.) but many are not. The ones that aren't blocked are really easy to add: usually 10min or less including writing test cases. If you'd like to try your hand at writing a lint sometime (e.g. "function becomes |
Remove functions deprecated in 0.41.0.
Description
Remove functions deprecated in 0.41.0.
Links to any relevant issues
Follows from: #3097 and #3119
Open Questions
None
Change checklist