-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] new task to create exclusion files from issues #432
[wip] new task to create exclusion files from issues #432
Conversation
Here's a generated example file:
|
The build for the versions 5.2.0 has been failing because of a bug in lightbend-labs/mima#432. To avoid falling into that bug, we add exclusion filters.
The build for the versions 5.2.0 has been failing because of a bug in lightbend-labs/mima#432. To avoid falling into that bug, we add exclusion filters.
So, while I understand how this can be a productivity boost, I'm concerned about two things:
So I'd really like not to include this... :-/ If you're happy to pivot to another resolution for your issues, I'd be happy to collaborate on resolving them, I'm thinking:
(That last one I've been wanting to fix for a long time, but it's tricky because it requires adding a lot of logic to the already present partial-reimplementation of an Unpickler, to get to the package private detail - and it needs to be an Unpickler that works for all versions of Scala, 2.11-2.13 currently. But we can definitely spend time on it as an alternative to this PR.) |
I agree in theory. The main reason for exclusions in akka projects is changes to internal classes, so fixing that would help a lot. In practice, I don't have time to fix issues in mima and every so often need to create lots of exclusion like for akka/akka#28294 which was not caused by any of the above issues but probably by some other bug. In those cases, I need a way to appease mima with as little effort as possible (I still need make sure that the errors are harmless indeed which is lots of work in itself). |
That's annotated classes? We can definitely start there - I'll try to find time for it.
That looks like it's #388, btw. Also, that PR seems to have had to pay back from the accidental misconfiguration of MiMa, which is unfortunate, but also exceptional.
I'd be fine for you and lots of other engineers, but not for the product in general... I'll think about it some more. |
Yes, maybe :) |
Let's try and fix MiMa. 💪 |
👍
Dale Wijnand <notifications@github.com> schrieb am Di., 18. Feb. 2020,
18:12:
… Closed #432 <#432>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#432>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACNDC2J4KB34QC7V6SVGDRDQJHDANCNFSM4JUXGL3A>
.
|
This is a WIP for a task to create exclusion files. We sometimes have the situation that you expect lots of exclusions because internal API was touched or similar in which case it is annoying to create those files manually from the console output, especially if multiple submodules are involved. This task creates the files directly where they should go and also add a bit of commentary for which versions they are needed.
This is still a WIP but since I don't know when I would get to finish it, I just dump it here.
Potential TODOs: