Allow arbitrary logger types. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
approved these changes
Aug 13, 2023
| // calculate the snapshot | ||
| let snapshot = super::serialize_delta(network_graph_clone, current_last_sync_timestamp.clone() as u32).await; | ||
| let snapshot = super::serialize_delta(network_graph_clone, current_last_sync_timestamp.clone() as u32, self.logger.clone()).await; |
There was a problem hiding this comment.
Here (and many many places) - you don't always have to clone, sometimes you can just pass by reference and it suffices :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to test some deeply nested functionality, such as the return values of queries. The best way to do so is using a test logger and asserting that a given log statement has been made.
Previously, the logger type was globally fixed. With this PR, logger types can be replaced such that the unit test suite will have the ability of using a test-specific logger. Additionally, all print statements needed to be replaced with log statements to make the test-specific logger useful.