-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node Reminders #84
Node Reminders #84
Commits on Aug 28, 2024
-
Create a config variable representing the time interval whereafter graph data gets pruned. This value should be used to limit lookup time frames.
Configuration menu - View commit details
-
Copy full SHA for 71b7345 - Browse repository at this point
Copy the full SHA 71b7345View commit details -
Rename latest_details_after_seen to latest_details.
If the latest node details have already been seen by a client, we still need to store them for correctly detecting reminder necessity in the future.
Configuration menu - View commit details
-
Copy full SHA for 86104e5 - Browse repository at this point
Copy the full SHA 86104e5View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8219e5d - Browse repository at this point
Copy the full SHA 8219e5dView commit details -
Only consider node announcements from current graph.
We want to ignore any node announcements that have already been pruned. To do so, we extract all the node IDs from the network graph, and use those to filter our queries.
Configuration menu - View commit details
-
Copy full SHA for 63aaf61 - Browse repository at this point
Copy the full SHA 63aaf61View commit details -
Extract snapshot reminder inclusion check method.
We will need to determine whether or not a snapshot should include reminders for both channel and node update messages. To prepare for that, we extract the decision logic into its own method.
Configuration menu - View commit details
-
Copy full SHA for f46b5ec - Browse repository at this point
Copy the full SHA f46b5ecView commit details -
Introduce node serialization strategy.
With the addition of reminders, we may encounter scenarios where either a bit flip may suffice, instructing the client to look up its latest data, or we may need to serialize all announcement details a new if the client may have already purged the old data. To better distinguish between these scenarios, we introduce a serialization strategy enum that allows serializing either the full announcement, just the mutations, or serve solely as a reminder and serialize nothing at all.
Configuration menu - View commit details
-
Copy full SHA for c9aaf09 - Browse repository at this point
Copy the full SHA c9aaf09View commit details -
Send full node announcements following old pre-sync updates.
This covers the following part of our serialization logic: If the pre-sync update was more than 6 days ago, serialize in full.
Configuration menu - View commit details
-
Copy full SHA for 1d78373 - Browse repository at this point
Copy the full SHA 1d78373View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9674f7 - Browse repository at this point
Copy the full SHA a9674f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7a9d62 - Browse repository at this point
Copy the full SHA d7a9d62View commit details