Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pluggable Authorizer, default to NoopAuthorizer #31

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

G8XSU
Copy link
Collaborator

@G8XSU G8XSU commented Jul 25, 2024

  • Add support for pluggable Authorizer, default to NoopAuthorizer

Different authorizers can act upon headers to return userToken or throw AuthException if auth fails.

We can later implement JWTAuthorizer or others.

If hosting providers, want to supply some other variant or add additional checks, they can just implement this interface.

Based on #30.

@G8XSU G8XSU force-pushed the authorizer branch 2 times, most recently from 3d86906 to 07d47d1 Compare July 29, 2024 19:16
@G8XSU G8XSU requested a review from jkczyz July 29, 2024 19:16
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. Otherwise, LGTM.

app/src/main/java/org/vss/api/AbstractVssApi.java Outdated Show resolved Hide resolved
app/src/main/java/org/vss/api/GetObjectApi.java Outdated Show resolved Hide resolved
app/src/main/java/org/vss/auth/NoopAuthorizer.java Outdated Show resolved Hide resolved
Different authorizers can act upon headers to return userToken
or throw AuthException if auth fails. If hosting providers,
want to support alternative auths or add additional checks in auth,
they can just implement this interface.
@G8XSU G8XSU merged commit c21fd71 into lightningdevkit:main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants