config+frcli: fix macaroon & tls cert path parsing #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the `faradayDirSet` boolean before namespacing the directory with the network. This fixes a bug where the user would _not_ set faradayDir but would set the macaroon path and would run into the "faradaydir overwrites macaroonpath..." error.
Only overwrite the default TLS cert and macaroon paths if the user has not explicitly defined them.
guggero
approved these changes
Aug 16, 2024
ViktorTigerstrom
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faradayDirSetboolean is accurately set. Otherwise it is always true & so will always result in errors when the user provides their own macaroon path when they dont set the faraday dir.Fixes #191