Upgrade lnd and Cancelable payment flag #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
cancelable-sendpayment
branch
2 times, most recently
from
b833d27
to
29c2c23
Compare
hieblmi
force-pushed
the
cancelable-sendpayment
branch
from
29c2c23
to
dbc452d
Compare
guggero
reviewed
Sep 20, 2024
router_client.go
Outdated
| @@ -284,6 +284,13 @@ type SendPaymentRequest struct { | |||
|
|
|||
| // AMP is set to true if the payment should be an AMP payment. | |||
| AMP bool | |||
|
|
|||
| // If set, the payment loop can be interrupted by manually canceling | |||
There was a problem hiding this comment.
nit: Godoc comments should start with the field name. Also, there are double spaces at the start of the comment.
hieblmi
force-pushed
the
cancelable-sendpayment
branch
from
dbc452d
to
50c5387
Compare
|
I think you need to revert the changes to |
bhandras
approved these changes
Sep 20, 2024
hieblmi
force-pushed
the
cancelable-sendpayment
branch
3 times, most recently
from
61c553e
to
0956c7a
Compare
This commit also updates the go version from 1.19 to 1.23
guggero
approved these changes
Sep 20, 2024
router_client.go
Outdated
| @@ -284,6 +284,13 @@ type SendPaymentRequest struct { | |||
|
|
|||
| // AMP is set to true if the payment should be an AMP payment. | |||
| AMP bool | |||
|
|
|||
| // Cancelable controls if the payment can be interrupted manually by | |||
There was a problem hiding this comment.
nit: double spaces still there...
hieblmi
force-pushed
the
cancelable-sendpayment
branch
from
0956c7a
to
60ce43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to lnd to
v0.18.3-betaand then addsCancelableto theSendPaymentRequest.