Add channel reserve as a constraint during order matching/expression #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstadulis
reviewed
Oct 31, 2022
| /* | ||
| Signals if this bid is interested in a minimal reserve channel. | ||
| */ | ||
| bool min_reserve_channel = 10; |
There was a problem hiding this comment.
My understanding is that there isn't anything endogenous to a "minimum reserve" channel that distinguishes it from another channel. That the distinguishing factor need to be produced by Pool, is the bidder is in essence setting a stipulation on the asker's performance, that their node update channel balances to channel-reserve levels Pool hasn't supported before (and hence what is considered "minimum reserve" is super nebulous and could change in the future).
Let's discuss internally how to best create matches around this property
ffranr
force-pushed
the
channel_reserve_constraint
branch
from
3f1e39c
to
3582501
Compare
|
For the record, per 2022-11-08 meeting this feature will be removed from sprints until work could resume in 2023-Q1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
used.