Fix quickstart npm install to also fetch the Lightpanda binary - #85
Open
cdebled wants to merge 1 commit into
Open
Fix quickstart npm install to also fetch the Lightpanda binary#85cdebled wants to merge 1 commit into
cdebled wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lightpanda/browservia npm only gets the JS library, not the browser binary, sonpm install --save @lightpanda/browseralone leaveslightpanda.serve()with nothing to spawn. Addednpx @lightpanda/browser installas a second step in the npm and pnpm tabs.npx @lightpanda/browser installover the curl one-liner (pkg.lightpanda.io/install.sh) because it uses theget.lightpanda.io/versions.jsonendpoint, more reliable thanapi.github.com, which the one-liner (and the package's own brokenpostinstallscript) depends on and which is prone to rate-limiting.@lightpanda/browser'spackage.jsondeclares"engines": {"yarn": "4"}, soyarn addhard-fails on Yarn Classic (v1), the default most people have.