Upgrade Biome to 2.5.11 and make CI actually run it - #89
Open
arrufat wants to merge 1 commit into
Open
Conversation
CI ran 'npx biome ci .', which resolves the unrelated 'biome' npm package rather than @biomejs/biome, so the lint job passed without checking anything. Install Biome through biomejs/setup-biome instead and pin the version. Migrate biome.json to the 2.x schema, enable Tailwind directives now that Biome parses CSS, and apply the formatting and import-order fixes the new version reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
npx biome ci .resolves the unrelatedbiomenpm package (an env-var manager), not@biomejs/biome, so the lint job passed in seconds without linting anything. The workflow now installs Biome throughbiomejs/setup-biomeand runsbiome ci .directly.@biomejs/biometo2.5.11(exact, as Biome recommends) and drop thenpx/yarn dlxindirection from the package scripts.biome.jsonto the 2.x schema withbiome migrate(files.ignore→files.includes,organizeImports→assist).css.parser.tailwindDirectivesfor the@apply/@tailwindrules insrc/stylesandglobals.css. The CSS files needed no reformatting.biome check --writereports on the existing sources: import ordering,import type, and formatting in six files. No behaviour changes.biome ci . --diagnostic-level=erroris clean on this branch.