Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fatal for ordinary consume errors #66

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Do not fatal for ordinary consume errors #66

merged 1 commit into from
Nov 9, 2023

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Nov 9, 2023

What is the current behavior?

The collector will exit because of a transient failure.

What is the new behavior?

It will log the failure.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests(make test) for the changes have been added (for bug fixes / features) and pass
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Lint (make lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

The process fails in a difficult to diagnose way!
It exits with status 0 and the log explaining why is nowhere near the bottom.

@jmacd jmacd requested a review from mwear November 9, 2023 21:21
@jmacd jmacd merged commit 99e4ffc into main Nov 9, 2023
3 checks passed
@jmacd jmacd deleted the jmacd/nofatal branch November 9, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants