Lint JS

ligoj · Sep 26, 2023 · dfa7196 · dfa7196
1 parent 833091a
commit dfa7196
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/main/java/org/ligoj/app/plugin/qa/sonar/SonarPluginResource.java b/src/main/java/org/ligoj/app/plugin/qa/sonar/SonarPluginResource.java
@@ -249,7 +249,8 @@ protected SonarProject getProject(final Map<String, String> parameters, final St
 		List<SonarBranch> branches = Collections.emptyList();
 
 		// Get the JSON project
-		final String queryUrl, defaultMetrics;
+		final String queryUrl;
+		final String defaultMetrics;
 		if (is63API(version)) {
 			queryUrl = "api/measures/component?component=" + encodedId + "&metricKeys=";
 			defaultMetrics = DEFAULT_METRICS_63;

diff --git a/src/main/java/org/ligoj/app/plugin/qa/sonar/SonarProjectList.java b/src/main/java/org/ligoj/app/plugin/qa/sonar/SonarProjectList.java
@@ -4,14 +4,10 @@
 package org.ligoj.app.plugin.qa.sonar;
 
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
-import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.Getter;
 import lombok.Setter;
-import org.ligoj.bootstrap.core.IDescribableBean;
-import org.ligoj.bootstrap.core.NamedBean;
 
 import java.util.List;
-import java.util.Map;
 
 /**
  * SonarQube project retrieved from REST API. Name, and also some additional

diff --git a/src/main/resources/META-INF/resources/webjars/service/qa/sonarqube/sonarqube.js b/src/main/resources/META-INF/resources/webjars/service/qa/sonarqube/sonarqube.js
@@ -1,5 +1,5 @@
 define(function () {
-	var current = {
+	const current = {
 
 		configureSubscriptionParameters: function (configuration) {
 			current.$super('registerXServiceSelect2')(configuration, 'service:qa:sonarqube:project', 'service/qa/sonarqube/');
@@ -76,7 +76,7 @@ define(function () {
                     }
                     description += `: ${value}`;
                 } else {
-                    if (value > 1000000) {
+                    if (value > 1000000000) {
                         displayValue = Math.round(value/1000000000);
                         unit = 'G';
                     } else if (value > 1000000) {
@@ -125,7 +125,7 @@ define(function () {
                  let branchMetrics = current.renderMetrics(subscription, b);
                  return `<div class="branch">${url}${branchMetrics}</div>`;
             }).join(' ');
-            return result + `${branches ? `<div class="branches">${branches}</div>`: ''}`;
+            return result + (branches ? `<div class="branches">${branches}</div>`: '');
 		}
 	};
 	return current;