This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Provide Flatpak package #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't work yet, because dependencies are missing. But this is somewhat how I imagine it to work.
Dependencies between files are now taken into account for the Flatpak related make targets.
That's usually the default, and that's usually where runtimes (like the org.freedesktop.Sdk that we need) are available
|
Please close this PR and reopen again https://github.com/trelby/trelby, as the project is merging into that project. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Not in this PR
Icon for the app
In order to be accessible on the host system, the icons needs to be moved to
/app/share/icons/hicolor/$size/apps/at installation. And they need to be referenced somehow in the.desktopfile. I don't really know a simple and good way to do this without breaking other installation methods right now, and for me, this doesn't have the highest priority. I'm glad if we have a Flatpak and it works :)Wayland support
Technically, Trelby should support Wayland, as the wxWidgets version it uses does (also, it works on my machine without the Flatpak). However, inside the Flatpak, it always tries to connect to the X server, even if only Wayland is available. That's why I had to give the Flatpak X11 permission, until someone figures out how to fix this.
Proper sandboxing
The only proper way for Flatpak permissions is requesting them on demand, only requesting access to the files the user wants to open and not to the whole file system. However, wxWidgets/Gtk3 don't support using the file opening portal, but rather use a classic file picker that requires file system access. That's why I had to stab a hole into the sandbox by declaring full file system access for the Flatpak.
Nightly build
I think it would be cool to have a build on any commit to the
mainbranch. But I don't know where to put these files and where to make them available for download. Edit: It seems like I can just declare them as artifacts and get download URLs for these. If this is as easy as it sounds, this might already be in this PR.Distribution in a public repository
I think, before we distribute anything in public repositories, we need to take care of the ownership of the trelby.org domain.