This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Implement horizontal scrolling #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By putting the Control into a ScrolledWindow, we get scroll bars whenever the Control's container is smaller than its minimum size. Vertical scrolling of the ScrolledWindow currently is deactivated, as we still have our custom implementation for vertical scrolling. This, however, raises some issues: At first, the vertical scroll bar gets scrolled away along with the Screenplay Control while scrolling horizontally, as it is part of the contents of the ScrolledWindow. Also, the hand-made scrollbar lacks some features, such as auto-hiding or the "precise scrolling mode" on Gtk. Eventually, the custom scrolling implementation is probably going to get in our way when implementing limburgher#20 anyway, so we should try to port vertical scrolling to the ScrolledWindow scrolling mechanism.
Before this commit, horizontal scrolling also moves the vertical scroll bar.
|
2 of the pipelines still fail, but this is a known issue. I consider this ready to merge. |
I specifically implemented fd5c593 to make this comment not necessary
|
I turned making the current character visible while typing into a separate issue (#86) so this can be merged, because you won't run into that when you don't use horizontal scrolling, so none of the previous use cases will be affected. |
|
Wonderful, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trelby uses a very complicated custom implementation for vertical scrolling, which can't be extended to work for horizontal scrolling.
In #72, there is an attempt to replace this custom implementation by using more of the toolkit's functionality. However, this is a huge projects that includes adjusting a lot of the rendering code and other parts of the application, which I'm not willing to invest right now.
This PR instead uses our wxWidgets toolkit for horizontal scrolling only, letting this implementation co-exist with the custom vertical scrolling implementation. #72 could later still be rebased on top of this in order to streamline the implementation and provide more native toolkit functionality also for vertical scrolling.
Horizontal scrolling is a necessary step towards implementing #20.