Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1201 User limit for mail restoration #1248

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

florentos17
Copy link
Contributor

the issue has been tackled in this PR but after merging Benoit Tellier commented the following:

As done for https://github.com/linagora/tmail-backend/blob/master/docs/modules/ROOT/pages/tmail-backend/jmap-extensions/deletedMessagesVault.adoc we would need to advertize in the JMAP session the restoration horizon.

maxRestaurationHorizon: String | null, defaulting to 15 days. Horizon past which users can no longer recover emails alone.

Why? It enables the frontend to present the limits to the user and enforce it in user input.

Of course we shall read it from the configuration.

@florentos17 florentos17 reopened this Oct 16, 2024
@florentos17 florentos17 force-pushed the User-Limit-For-Mail-Restoration branch from 46f8f54 to 95d4123 Compare October 16, 2024 15:29
@florentos17
Copy link
Contributor Author

sorry, i reused an old branch on which there were other commits, hence the force push.

@chibenwa
Copy link
Member

Are those documented items of the jMAP vault capability actually implemented?

Or is this documentation ahead of its time?

private def capability(): CapabilityFactory = MessageVaultCapabilityFactory

Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the doc do not describe the actual behaviour: it needs to be implemented!

Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EmailRecoveryAction/set shall also depend on the configuration file created...

@Arsnael
Copy link
Member

Arsnael commented Oct 22, 2024

[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.9.1:compile (scala-compile-first) on project jmap-extensions: Execution scala-compile-first of goal net.alchim31.maven:scala-maven-plugin:4.9.1:compile failed: Compilation failed: InterfaceCompileFailed -> [Help 1]

@florentos17 florentos17 force-pushed the User-Limit-For-Mail-Restoration branch from fcb5b5e to f83d046 Compare October 24, 2024 12:42
@florentos17
Copy link
Contributor Author

i finished documenting the format, the pipeline was all green so i cleaned the commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants