-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-1201 User limit for mail restoration #1248
base: master
Are you sure you want to change the base?
ISSUE-1201 User limit for mail restoration #1248
Conversation
46f8f54
to
95d4123
Compare
sorry, i reused an old branch on which there were other commits, hence the force push. |
Are those documented items of the jMAP vault capability actually implemented? Or is this documentation ahead of its time? Line 27 in 0096ae9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the doc do not describe the actual behaviour: it needs to be implemented!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmailRecoveryAction/set shall also depend on the configuration file created...
...jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/MessageVaultConfiguration.scala
Outdated
Show resolved
Hide resolved
.../extensions/src/main/scala/com/linagora/tmail/james/jmap/method/MessageVaultCapability.scala
Outdated
Show resolved
Hide resolved
.../extensions/src/main/scala/com/linagora/tmail/james/jmap/method/MessageVaultCapability.scala
Outdated
Show resolved
Hide resolved
.../extensions/src/main/scala/com/linagora/tmail/james/jmap/method/MessageVaultCapability.scala
Outdated
Show resolved
Hide resolved
[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.9.1:compile (scala-compile-first) on project jmap-extensions: Execution scala-compile-first of goal net.alchim31.maven:scala-maven-plugin:4.9.1:compile failed: Compilation failed: InterfaceCompileFailed -> [Help 1] |
...s-common/src/main/scala/com/linagora/tmail/james/common/MessageVaultCapabilityContract.scala
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/tmail-backend/jmap-extensions/deletedMessagesVault.adoc
Outdated
Show resolved
Hide resolved
...s-common/src/main/scala/com/linagora/tmail/james/common/MessageVaultCapabilityContract.scala
Outdated
Show resolved
Hide resolved
...s-common/src/main/scala/com/linagora/tmail/james/common/MessageVaultCapabilityContract.scala
Outdated
Show resolved
Hide resolved
...tegration-tests/src/test/java/com/linagora/tmail/james/MemoryMessageVaultCapabilityTest.java
Outdated
Show resolved
Hide resolved
...tegration-tests/src/test/java/com/linagora/tmail/james/MemoryMessageVaultCapabilityTest.java
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/tmail-backend/jmap-extensions/deletedMessagesVault.adoc
Outdated
Show resolved
Hide resolved
fcb5b5e
to
f83d046
Compare
i finished documenting the format, the pipeline was all green so i cleaned the commit history |
the issue has been tackled in this PR but after merging Benoit Tellier commented the following: