Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloads where tract, patch and object id are not present in the catalog. #63

Open
3 tasks done
aritraghsh09 opened this issue Sep 13, 2024 · 1 comment
Open
3 tasks done
Labels
Downloader Downloader code primarily enhancement New feature or request

Comments

@aritraghsh09
Copy link
Collaborator

Feature request

  • It is not uncommon for astronomers to only have RA/DEC positions available for a download (without any information on tract, patch, or object id).
  • The downloader should be able to skip the sort step in these situations and send requests to the HSC service only with RA, DEC positions.
  • We should warn the user that having the tract, patch info will speed up the download.
  • If the user does not provide any object_ids, we should say that we will just return the order in the list (0,1,2,3...) as the object ID in the manifest.

Before submitting
Please check the following:

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@aritraghsh09 aritraghsh09 added enhancement New feature or request Downloader Downloader code primarily labels Sep 13, 2024
@mtauraso
Copy link
Collaborator

mtauraso commented Sep 14, 2024

This may very nearly work already. Rects are dataclasses and though tract is part of the sort, its perfectly valid to make a bunch of Rects with tract=None and they will sort just fine.

Probably this will have issues in the downloader because of the hardcoded list of fields that includes tract and that is what will need to be worked around.

object_ids I'm less sure of, but we might be able to work without them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Downloader Downloader code primarily enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants